From 633a3ba03adf9983e361efe994f34d405b573cbc Mon Sep 17 00:00:00 2001
From: David Hill <iamdavidhill@gmail.com>
Date: Mon, 2 Mar 2026 16:05:16 +0000
Subject: [PATCH] ui: avoid session review header clipping

Move the session review header outside the scroll viewport and drop strict containment so shadows can render without being cropped.
---
 packages/ui/src/components/session-review.css |  13 +-
 packages/ui/src/components/session-review.tsx | 577 +++++++++---------
 2 files changed, 295 insertions(+), 295 deletions(-)

diff --git a/packages/ui/src/components/session-review.css b/packages/ui/src/components/session-review.css
index dfbb171d8..014a70e74 100644
--- a/packages/ui/src/components/session-review.css
+++ b/packages/ui/src/components/session-review.css
@@ -3,11 +3,10 @@
   flex-direction: column;
   gap: 0px;
   height: 100%;
-  overflow-y: auto;
-  scrollbar-width: none;
-  contain: strict;
-  &::-webkit-scrollbar {
-    display: none;
+
+  [data-slot="session-review-scroll"] {
+    flex: 1 1 auto;
+    min-height: 0;
   }
 
   .scroll-view__viewport {
@@ -21,8 +20,6 @@
   }
 
   [data-slot="session-review-header"] {
-    position: sticky;
-    top: 0;
     z-index: 120;
     background-color: var(--background-stronger);
     height: 40px;
@@ -63,7 +60,7 @@
   }
 
   [data-component="sticky-accordion-header"] {
-    --sticky-accordion-top: 40px;
+    --sticky-accordion-top: 0px;
   }
 
   [data-slot="session-review-accordion-item"][data-selected]
diff --git a/packages/ui/src/components/session-review.tsx b/packages/ui/src/components/session-review.tsx
index 77bd9506d..2f74207d5 100644
--- a/packages/ui/src/components/session-review.tsx
+++ b/packages/ui/src/components/session-review.tsx
@@ -554,20 +554,7 @@ export const SessionReview = (props: SessionReviewProps) => {
   }
 
   return (
-    <ScrollView
-      data-component="session-review"
-      viewportRef={(el) => {
-        scroll = el
-        props.scrollRef?.(el)
-      }}
-      onScroll={props.onScroll as any}
-      onKeyDown={handleReviewKeyDown}
-      classList={{
-        ...(props.classList ?? {}),
-        [props.classes?.root ?? ""]: !!props.classes?.root,
-        [props.class ?? ""]: !!props.class,
-      }}
-    >
+    <div data-component="session-review" class={props.class} classList={props.classList}>
       <div data-slot="session-review-header" class={props.classes?.header}>
         <div data-slot="session-review-title">{props.title ?? i18n.t("ui.sessionReview.title")}</div>
         <div data-slot="session-review-actions">
@@ -599,301 +586,317 @@ export const SessionReview = (props: SessionReviewProps) => {
           {props.actions}
         </div>
       </div>
-      <Show when={searchOpen()}>
-        <FileSearchBar
-          pos={searchPos}
-          query={searchQuery}
-          index={() => (searchHits().length ? Math.min(searchActive(), searchHits().length - 1) : 0)}
-          count={() => searchHits().length}
-          setInput={(el) => {
-            searchInput = el
-          }}
-          onInput={(value) => {
-            setSearchQuery(value)
-            setSearchActive(0)
-          }}
-          onKeyDown={(event) => handleSearchInputKeyDown(event)}
-          onClose={closeSearch}
-          onPrev={() => navigateSearch(-1)}
-          onNext={() => navigateSearch(1)}
-        />
-      </Show>
-      <div data-slot="session-review-container" class={props.classes?.container}>
-        <Show when={hasDiffs()} fallback={props.empty}>
-          <Accordion multiple value={open()} onChange={handleChange}>
-            <For each={files()}>
-              {(file) => {
-                let wrapper: HTMLDivElement | undefined
 
-                const diff = createMemo(() => diffs().get(file))
-                const item = () => diff()!
+      <ScrollView
+        data-slot="session-review-scroll"
+        viewportRef={(el) => {
+          scroll = el
+          props.scrollRef?.(el)
+        }}
+        onScroll={props.onScroll as any}
+        onKeyDown={handleReviewKeyDown}
+        classList={{
+          [props.classes?.root ?? ""]: !!props.classes?.root,
+        }}
+      >
+        <Show when={searchOpen()}>
+          <FileSearchBar
+            pos={searchPos}
+            query={searchQuery}
+            index={() => (searchHits().length ? Math.min(searchActive(), searchHits().length - 1) : 0)}
+            count={() => searchHits().length}
+            setInput={(el) => {
+              searchInput = el
+            }}
+            onInput={(value) => {
+              setSearchQuery(value)
+              setSearchActive(0)
+            }}
+            onKeyDown={(event) => handleSearchInputKeyDown(event)}
+            onClose={closeSearch}
+            onPrev={() => navigateSearch(-1)}
+            onNext={() => navigateSearch(1)}
+          />
+        </Show>
 
-                const expanded = createMemo(() => open().includes(file))
-                const force = () => !!store.force[file]
+        <div data-slot="session-review-container" class={props.classes?.container}>
+          <Show when={hasDiffs()} fallback={props.empty}>
+            <Accordion multiple value={open()} onChange={handleChange}>
+              <For each={files()}>
+                {(file) => {
+                  let wrapper: HTMLDivElement | undefined
 
-                const comments = createMemo(() => (props.comments ?? []).filter((c) => c.file === file))
-                const commentedLines = createMemo(() => comments().map((c) => c.selection))
+                  const diff = createMemo(() => diffs().get(file))
+                  const item = () => diff()!
 
-                const beforeText = () => (typeof item().before === "string" ? item().before : "")
-                const afterText = () => (typeof item().after === "string" ? item().after : "")
-                const changedLines = () => item().additions + item().deletions
-                const mediaKind = createMemo(() => mediaKindFromPath(file))
+                  const expanded = createMemo(() => open().includes(file))
+                  const force = () => !!store.force[file]
 
-                const tooLarge = createMemo(() => {
-                  if (!expanded()) return false
-                  if (force()) return false
-                  if (mediaKind()) return false
-                  return changedLines() > MAX_DIFF_CHANGED_LINES
-                })
+                  const comments = createMemo(() => (props.comments ?? []).filter((c) => c.file === file))
+                  const commentedLines = createMemo(() => comments().map((c) => c.selection))
 
-                const isAdded = () => item().status === "added" || (beforeText().length === 0 && afterText().length > 0)
-                const isDeleted = () =>
-                  item().status === "deleted" || (afterText().length === 0 && beforeText().length > 0)
+                  const beforeText = () => (typeof item().before === "string" ? item().before : "")
+                  const afterText = () => (typeof item().after === "string" ? item().after : "")
+                  const changedLines = () => item().additions + item().deletions
+                  const mediaKind = createMemo(() => mediaKindFromPath(file))
 
-                const selectedLines = createMemo(() => {
-                  const current = selection()
-                  if (!current || current.file !== file) return null
-                  return current.range
-                })
+                  const tooLarge = createMemo(() => {
+                    if (!expanded()) return false
+                    if (force()) return false
+                    if (mediaKind()) return false
+                    return changedLines() > MAX_DIFF_CHANGED_LINES
+                  })
 
-                const draftRange = createMemo(() => {
-                  const current = commenting()
-                  if (!current || current.file !== file) return null
-                  return current.range
-                })
+                  const isAdded = () =>
+                    item().status === "added" || (beforeText().length === 0 && afterText().length > 0)
+                  const isDeleted = () =>
+                    item().status === "deleted" || (afterText().length === 0 && beforeText().length > 0)
 
-                const commentsUi = createLineCommentController<SessionReviewComment>({
-                  comments,
-                  label: i18n.t("ui.lineComment.submit"),
-                  draftKey: () => file,
-                  state: {
-                    opened: () => {
-                      const current = opened()
-                      if (!current || current.file !== file) return null
-                      return current.id
+                  const selectedLines = createMemo(() => {
+                    const current = selection()
+                    if (!current || current.file !== file) return null
+                    return current.range
+                  })
+
+                  const draftRange = createMemo(() => {
+                    const current = commenting()
+                    if (!current || current.file !== file) return null
+                    return current.range
+                  })
+
+                  const commentsUi = createLineCommentController<SessionReviewComment>({
+                    comments,
+                    label: i18n.t("ui.lineComment.submit"),
+                    draftKey: () => file,
+                    state: {
+                      opened: () => {
+                        const current = opened()
+                        if (!current || current.file !== file) return null
+                        return current.id
+                      },
+                      setOpened: (id) => setOpened(id ? { file, id } : null),
+                      selected: selectedLines,
+                      setSelected: (range) => setSelection(range ? { file, range } : null),
+                      commenting: draftRange,
+                      setCommenting: (range) => setCommenting(range ? { file, range } : null),
                     },
-                    setOpened: (id) => setOpened(id ? { file, id } : null),
-                    selected: selectedLines,
-                    setSelected: (range) => setSelection(range ? { file, range } : null),
-                    commenting: draftRange,
-                    setCommenting: (range) => setCommenting(range ? { file, range } : null),
-                  },
-                  getSide: selectionSide,
-                  clearSelectionOnSelectionEndNull: false,
-                  onSubmit: ({ comment, selection }) => {
-                    props.onLineComment?.({
-                      file,
-                      selection,
-                      comment,
-                      preview: selectionPreview(item(), selection),
-                    })
-                  },
-                  onUpdate: ({ id, comment, selection }) => {
-                    props.onLineCommentUpdate?.({
-                      id,
-                      file,
-                      selection,
-                      comment,
-                      preview: selectionPreview(item(), selection),
-                    })
-                  },
-                  onDelete: (comment) => {
-                    props.onLineCommentDelete?.({
-                      id: comment.id,
-                      file,
-                    })
-                  },
-                  editSubmitLabel: props.lineCommentActions?.saveLabel,
-                  renderCommentActions: props.lineCommentActions
-                    ? (comment, controls) => (
-                        <ReviewCommentMenu
-                          labels={props.lineCommentActions!}
-                          onEdit={controls.edit}
-                          onDelete={controls.remove}
-                        />
-                      )
-                    : undefined,
-                })
+                    getSide: selectionSide,
+                    clearSelectionOnSelectionEndNull: false,
+                    onSubmit: ({ comment, selection }) => {
+                      props.onLineComment?.({
+                        file,
+                        selection,
+                        comment,
+                        preview: selectionPreview(item(), selection),
+                      })
+                    },
+                    onUpdate: ({ id, comment, selection }) => {
+                      props.onLineCommentUpdate?.({
+                        id,
+                        file,
+                        selection,
+                        comment,
+                        preview: selectionPreview(item(), selection),
+                      })
+                    },
+                    onDelete: (comment) => {
+                      props.onLineCommentDelete?.({
+                        id: comment.id,
+                        file,
+                      })
+                    },
+                    editSubmitLabel: props.lineCommentActions?.saveLabel,
+                    renderCommentActions: props.lineCommentActions
+                      ? (comment, controls) => (
+                          <ReviewCommentMenu
+                            labels={props.lineCommentActions!}
+                            onEdit={controls.edit}
+                            onDelete={controls.remove}
+                          />
+                        )
+                      : undefined,
+                  })
 
-                onCleanup(() => {
-                  anchors.delete(file)
-                  readyFiles.delete(file)
-                  searchHandles.delete(file)
-                  if (highlightedFile === file) highlightedFile = undefined
-                })
+                  onCleanup(() => {
+                    anchors.delete(file)
+                    readyFiles.delete(file)
+                    searchHandles.delete(file)
+                    if (highlightedFile === file) highlightedFile = undefined
+                  })
 
-                const handleLineSelected = (range: SelectedLineRange | null) => {
-                  if (!props.onLineComment) return
-                  commentsUi.onLineSelected(range)
-                }
+                  const handleLineSelected = (range: SelectedLineRange | null) => {
+                    if (!props.onLineComment) return
+                    commentsUi.onLineSelected(range)
+                  }
 
-                const handleLineSelectionEnd = (range: SelectedLineRange | null) => {
-                  if (!props.onLineComment) return
-                  commentsUi.onLineSelectionEnd(range)
-                }
+                  const handleLineSelectionEnd = (range: SelectedLineRange | null) => {
+                    if (!props.onLineComment) return
+                    commentsUi.onLineSelectionEnd(range)
+                  }
 
-                return (
-                  <Accordion.Item
-                    value={file}
-                    id={diffId(file)}
-                    data-file={file}
-                    data-slot="session-review-accordion-item"
-                    data-selected={props.focusedFile === file ? "" : undefined}
-                  >
-                    <StickyAccordionHeader>
-                      <Accordion.Trigger>
-                        <div data-slot="session-review-trigger-content">
-                          <div data-slot="session-review-file-info">
-                            <FileIcon node={{ path: file, type: "file" }} />
-                            <div data-slot="session-review-file-name-container">
-                              <Show when={file.includes("/")}>
-                                <span data-slot="session-review-directory">{`\u202A${getDirectory(file)}\u202C`}</span>
-                              </Show>
-                              <span data-slot="session-review-filename">{getFilename(file)}</span>
-                              <Show when={props.onViewFile}>
-                                <Tooltip value={openFileLabel()} placement="top" gutter={4}>
-                                  <button
-                                    data-slot="session-review-view-button"
-                                    type="button"
-                                    aria-label={openFileLabel()}
-                                    onClick={(e) => {
-                                      e.stopPropagation()
-                                      props.onViewFile?.(file)
-                                    }}
-                                  >
-                                    <Icon name="open-file" size="small" />
-                                  </button>
-                                </Tooltip>
-                              </Show>
+                  return (
+                    <Accordion.Item
+                      value={file}
+                      id={diffId(file)}
+                      data-file={file}
+                      data-slot="session-review-accordion-item"
+                      data-selected={props.focusedFile === file ? "" : undefined}
+                    >
+                      <StickyAccordionHeader>
+                        <Accordion.Trigger>
+                          <div data-slot="session-review-trigger-content">
+                            <div data-slot="session-review-file-info">
+                              <FileIcon node={{ path: file, type: "file" }} />
+                              <div data-slot="session-review-file-name-container">
+                                <Show when={file.includes("/")}>
+                                  <span data-slot="session-review-directory">{`\u202A${getDirectory(file)}\u202C`}</span>
+                                </Show>
+                                <span data-slot="session-review-filename">{getFilename(file)}</span>
+                                <Show when={props.onViewFile}>
+                                  <Tooltip value={openFileLabel()} placement="top" gutter={4}>
+                                    <button
+                                      data-slot="session-review-view-button"
+                                      type="button"
+                                      aria-label={openFileLabel()}
+                                      onClick={(e) => {
+                                        e.stopPropagation()
+                                        props.onViewFile?.(file)
+                                      }}
+                                    >
+                                      <Icon name="open-file" size="small" />
+                                    </button>
+                                  </Tooltip>
+                                </Show>
+                              </div>
+                            </div>
+                            <div data-slot="session-review-trigger-actions">
+                              <Switch>
+                                <Match when={isAdded()}>
+                                  <div data-slot="session-review-change-group" data-type="added">
+                                    <span data-slot="session-review-change" data-type="added">
+                                      {i18n.t("ui.sessionReview.change.added")}
+                                    </span>
+                                    <DiffChanges changes={item()} />
+                                  </div>
+                                </Match>
+                                <Match when={isDeleted()}>
+                                  <span data-slot="session-review-change" data-type="removed">
+                                    {i18n.t("ui.sessionReview.change.removed")}
+                                  </span>
+                                </Match>
+                                <Match when={!!mediaKind()}>
+                                  <span data-slot="session-review-change" data-type="modified">
+                                    {i18n.t("ui.sessionReview.change.modified")}
+                                  </span>
+                                </Match>
+                                <Match when={true}>
+                                  <DiffChanges changes={item()} />
+                                </Match>
+                              </Switch>
+                              <span data-slot="session-review-diff-chevron">
+                                <Icon name="chevron-down" size="small" />
+                              </span>
                             </div>
                           </div>
-                          <div data-slot="session-review-trigger-actions">
+                        </Accordion.Trigger>
+                      </StickyAccordionHeader>
+                      <Accordion.Content data-slot="session-review-accordion-content">
+                        <div
+                          data-slot="session-review-diff-wrapper"
+                          ref={(el) => {
+                            wrapper = el
+                            anchors.set(file, el)
+                          }}
+                        >
+                          <Show when={expanded()}>
                             <Switch>
-                              <Match when={isAdded()}>
-                                <div data-slot="session-review-change-group" data-type="added">
-                                  <span data-slot="session-review-change" data-type="added">
-                                    {i18n.t("ui.sessionReview.change.added")}
-                                  </span>
-                                  <DiffChanges changes={item()} />
+                              <Match when={tooLarge()}>
+                                <div data-slot="session-review-large-diff">
+                                  <div data-slot="session-review-large-diff-title">
+                                    {i18n.t("ui.sessionReview.largeDiff.title")}
+                                  </div>
+                                  <div data-slot="session-review-large-diff-meta">
+                                    {i18n.t("ui.sessionReview.largeDiff.meta", {
+                                      limit: MAX_DIFF_CHANGED_LINES.toLocaleString(),
+                                      current: changedLines().toLocaleString(),
+                                    })}
+                                  </div>
+                                  <div data-slot="session-review-large-diff-actions">
+                                    <Button
+                                      size="normal"
+                                      variant="secondary"
+                                      onClick={() => setStore("force", file, true)}
+                                    >
+                                      {i18n.t("ui.sessionReview.largeDiff.renderAnyway")}
+                                    </Button>
+                                  </div>
                                 </div>
                               </Match>
-                              <Match when={isDeleted()}>
-                                <span data-slot="session-review-change" data-type="removed">
-                                  {i18n.t("ui.sessionReview.change.removed")}
-                                </span>
-                              </Match>
-                              <Match when={!!mediaKind()}>
-                                <span data-slot="session-review-change" data-type="modified">
-                                  {i18n.t("ui.sessionReview.change.modified")}
-                                </span>
-                              </Match>
                               <Match when={true}>
-                                <DiffChanges changes={item()} />
+                                <Dynamic
+                                  component={fileComponent}
+                                  mode="diff"
+                                  preloadedDiff={item().preloaded}
+                                  diffStyle={diffStyle()}
+                                  expansionLineCount={searchExpanded() ? Number.MAX_SAFE_INTEGER : 20}
+                                  onRendered={() => {
+                                    readyFiles.add(file)
+                                    props.onDiffRendered?.()
+                                  }}
+                                  enableLineSelection={props.onLineComment != null}
+                                  enableHoverUtility={props.onLineComment != null}
+                                  onLineSelected={handleLineSelected}
+                                  onLineSelectionEnd={handleLineSelectionEnd}
+                                  onLineNumberSelectionEnd={commentsUi.onLineNumberSelectionEnd}
+                                  annotations={commentsUi.annotations()}
+                                  renderAnnotation={commentsUi.renderAnnotation}
+                                  renderHoverUtility={props.onLineComment ? commentsUi.renderHoverUtility : undefined}
+                                  selectedLines={selectedLines()}
+                                  commentedLines={commentedLines()}
+                                  search={{
+                                    shortcuts: "disabled",
+                                    showBar: false,
+                                    disableVirtualization: searchExpanded(),
+                                    register: (handle: FileSearchHandle | null) => {
+                                      if (!handle) {
+                                        searchHandles.delete(file)
+                                        readyFiles.delete(file)
+                                        if (highlightedFile === file) highlightedFile = undefined
+                                        return
+                                      }
+
+                                      searchHandles.set(file, handle)
+                                    },
+                                  }}
+                                  before={{
+                                    name: file,
+                                    contents: typeof item().before === "string" ? item().before : "",
+                                  }}
+                                  after={{
+                                    name: file,
+                                    contents: typeof item().after === "string" ? item().after : "",
+                                  }}
+                                  media={{
+                                    mode: "auto",
+                                    path: file,
+                                    before: item().before,
+                                    after: item().after,
+                                    readFile: props.readFile,
+                                  }}
+                                />
                               </Match>
                             </Switch>
-                            <span data-slot="session-review-diff-chevron">
-                              <Icon name="chevron-down" size="small" />
-                            </span>
-                          </div>
+                          </Show>
                         </div>
-                      </Accordion.Trigger>
-                    </StickyAccordionHeader>
-                    <Accordion.Content data-slot="session-review-accordion-content">
-                      <div
-                        data-slot="session-review-diff-wrapper"
-                        ref={(el) => {
-                          wrapper = el
-                          anchors.set(file, el)
-                        }}
-                      >
-                        <Show when={expanded()}>
-                          <Switch>
-                            <Match when={tooLarge()}>
-                              <div data-slot="session-review-large-diff">
-                                <div data-slot="session-review-large-diff-title">
-                                  {i18n.t("ui.sessionReview.largeDiff.title")}
-                                </div>
-                                <div data-slot="session-review-large-diff-meta">
-                                  {i18n.t("ui.sessionReview.largeDiff.meta", {
-                                    limit: MAX_DIFF_CHANGED_LINES.toLocaleString(),
-                                    current: changedLines().toLocaleString(),
-                                  })}
-                                </div>
-                                <div data-slot="session-review-large-diff-actions">
-                                  <Button
-                                    size="normal"
-                                    variant="secondary"
-                                    onClick={() => setStore("force", file, true)}
-                                  >
-                                    {i18n.t("ui.sessionReview.largeDiff.renderAnyway")}
-                                  </Button>
-                                </div>
-                              </div>
-                            </Match>
-                            <Match when={true}>
-                              <Dynamic
-                                component={fileComponent}
-                                mode="diff"
-                                preloadedDiff={item().preloaded}
-                                diffStyle={diffStyle()}
-                                expansionLineCount={searchExpanded() ? Number.MAX_SAFE_INTEGER : 20}
-                                onRendered={() => {
-                                  readyFiles.add(file)
-                                  props.onDiffRendered?.()
-                                }}
-                                enableLineSelection={props.onLineComment != null}
-                                enableHoverUtility={props.onLineComment != null}
-                                onLineSelected={handleLineSelected}
-                                onLineSelectionEnd={handleLineSelectionEnd}
-                                onLineNumberSelectionEnd={commentsUi.onLineNumberSelectionEnd}
-                                annotations={commentsUi.annotations()}
-                                renderAnnotation={commentsUi.renderAnnotation}
-                                renderHoverUtility={props.onLineComment ? commentsUi.renderHoverUtility : undefined}
-                                selectedLines={selectedLines()}
-                                commentedLines={commentedLines()}
-                                search={{
-                                  shortcuts: "disabled",
-                                  showBar: false,
-                                  disableVirtualization: searchExpanded(),
-                                  register: (handle: FileSearchHandle | null) => {
-                                    if (!handle) {
-                                      searchHandles.delete(file)
-                                      readyFiles.delete(file)
-                                      if (highlightedFile === file) highlightedFile = undefined
-                                      return
-                                    }
-
-                                    searchHandles.set(file, handle)
-                                  },
-                                }}
-                                before={{
-                                  name: file,
-                                  contents: typeof item().before === "string" ? item().before : "",
-                                }}
-                                after={{
-                                  name: file,
-                                  contents: typeof item().after === "string" ? item().after : "",
-                                }}
-                                media={{
-                                  mode: "auto",
-                                  path: file,
-                                  before: item().before,
-                                  after: item().after,
-                                  readFile: props.readFile,
-                                }}
-                              />
-                            </Match>
-                          </Switch>
-                        </Show>
-                      </div>
-                    </Accordion.Content>
-                  </Accordion.Item>
-                )
-              }}
-            </For>
-          </Accordion>
-        </Show>
-      </div>
-    </ScrollView>
+                      </Accordion.Content>
+                    </Accordion.Item>
+                  )
+                }}
+              </For>
+            </Accordion>
+          </Show>
+        </div>
+      </ScrollView>
+    </div>
   )
 }